From 89fa67a317379f0d0b3942033f42b69e0c0c45bc Mon Sep 17 00:00:00 2001
From: Aaron Lefkowitz <aaron.lefkowitz@hpe.com>
Date: Fri, 22 Apr 2016 11:08:26 -0700
Subject: [PATCH] Fix bashisms.

I have a feeling this script was created on OSX because then it would be
being executed using on old bash in strict mode. On Ubuntu 14.04 though
it's executed using dash and various parts fall over because there's a
bunch of bash-specific code in here.

I corrected the problems that the checkbashisms script reported and it
seems to be working better now.

- Use printf instead of echo where escapes are necessary.
- Don't use double bracketed if statements where unnecessary.
- Use -o instead of ||
---
 bin/git-vendor | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/bin/git-vendor b/bin/git-vendor
index f4b130a..566aa59 100755
--- a/bin/git-vendor
+++ b/bin/git-vendor
@@ -32,12 +32,11 @@ case "$command" in
 esac
 
 prefix="vendor"
-if [ "$1" == "--prefix" ]; then
+if [ "$1" = "--prefix" ]; then
     prefix="$2"
     shift; shift
 fi
 
-
 vendor_names_from_log()
 {
     name=
@@ -108,16 +107,16 @@ cmd_list()
                     git-vendor-ref:) ref="$b" ;;
 		    git-vendor-repository:) repository="$b" ;;
 		    END)
-                        if [[ ! -z "$repository" ]];
+                        if [ ! -z "$repository" ];
                         then
-                            if [[ -z "$showOnly" ]] || [ "$showOnly" == "$name" ]; then
-                                echo "$name@$ref:"
-                                echo "\tname:\t$name"
-                                echo "\tdir:\t$dir"
-                                echo "\trepo:\t$repository"
-                                echo "\tref:\t$ref"
-                                echo "\tcommit:\t$commit"
-                                echo ""
+                            if [ -z "$showOnly" -o "$showOnly" = "$name" ]; then
+                                printf "$name@$ref:\n"
+                                printf "\tname:\t$name\n"
+                                printf "\tdir:\t$dir\n"
+                                printf "\trepo:\t$repository\n"
+                                printf "\tref:\t$ref\n"
+                                printf "\tcommit:\t$commit\n"
+                                printf "\n"
                             fi
                         fi
                         name=
@@ -155,7 +154,7 @@ cmd_update()
                         die "Dependency \"$1\" is missing from \"$dir\""
                     fi
 
-                    if [[ ! -z "$repository" ]];
+                    if [ ! -z "$repository" ];
                     then
                         message="\
 Update \"$name\" from \"$repository@$ref\"