Browse Source

add ListOptions field to ListMembersOptions

Will Norris 12 years ago
parent
commit
34a4afeea7
2 changed files with 11 additions and 2 deletions
  1. +2
    -0
      github/orgs_members.go
  2. +9
    -2
      github/orgs_members_test.go

+ 2
- 0
github/orgs_members.go View File

@ -17,6 +17,8 @@ type ListMembersOptions struct {
// Filter members returned in the list. Possible values are: // Filter members returned in the list. Possible values are:
// 2fa_disabled, all. Default is "all". // 2fa_disabled, all. Default is "all".
Filter string `url:"filter,omitempty"` Filter string `url:"filter,omitempty"`
ListOptions
} }
// ListMembers lists the members for an organization. If the authenticated // ListMembers lists the members for an organization. If the authenticated


+ 9
- 2
github/orgs_members_test.go View File

@ -18,11 +18,18 @@ func TestOrganizationsService_ListMembers(t *testing.T) {
mux.HandleFunc("/orgs/o/members", func(w http.ResponseWriter, r *http.Request) { mux.HandleFunc("/orgs/o/members", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "GET") testMethod(t, r, "GET")
testFormValues(t, r, values{"filter": "2fa_disabled"})
testFormValues(t, r, values{
"filter": "2fa_disabled",
"page": "2",
})
fmt.Fprint(w, `[{"id":1}]`) fmt.Fprint(w, `[{"id":1}]`)
}) })
opt := &ListMembersOptions{PublicOnly: false, Filter: "2fa_disabled"}
opt := &ListMembersOptions{
PublicOnly: false,
Filter: "2fa_disabled",
ListOptions: ListOptions{Page: 2},
}
members, _, err := client.Organizations.ListMembers("o", opt) members, _, err := client.Organizations.ListMembers("o", opt)
if err != nil { if err != nil {
t.Errorf("Organizations.ListMembers returned error: %v", err) t.Errorf("Organizations.ListMembers returned error: %v", err)


Loading…
Cancel
Save