From 386323a6edcd74962da674f36df8489f5b1fbe4b Mon Sep 17 00:00:00 2001 From: Carl Jackson Date: Sun, 23 Mar 2014 13:02:45 -0700 Subject: [PATCH] HTTP method names are case sensitive Who knew! (RFC 2616, 5.1.1) --- web/middleware/options.go | 2 +- web/router.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/web/middleware/options.go b/web/middleware/options.go index c8ed63c..d267ca9 100644 --- a/web/middleware/options.go +++ b/web/middleware/options.go @@ -18,7 +18,7 @@ func AutomaticOptions(c *web.C, h http.Handler) http.Handler { // 404 route anyways. var fw *httptest.ResponseRecorder pw := w - if strings.ToUpper(r.Method) == "OPTIONS" { + if r.Method == "OPTIONS" { fw = httptest.NewRecorder() pw = fw } diff --git a/web/router.go b/web/router.go index 02315da..86041ef 100644 --- a/web/router.go +++ b/web/router.go @@ -129,7 +129,7 @@ func parseHandler(h interface{}) Handler { } func httpMethod(mname string) method { - if method, ok := validMethodsMap[strings.ToUpper(mname)]; ok { + if method, ok := validMethodsMap[mname]; ok { return method } return mIDK