From 9f2a72abf206d7732b7cf04945309292ebada42a Mon Sep 17 00:00:00 2001 From: Will Norris Date: Thu, 10 Apr 2014 11:29:03 -0700 Subject: [PATCH] remove Users.EditKey method User keys can no longer be updated. Instead, they should be deleted and re-added. --- github/users_keys.go | 20 -------------------- github/users_keys_test.go | 29 ----------------------------- 2 files changed, 49 deletions(-) diff --git a/github/users_keys.go b/github/users_keys.go index 7b4ad1e..6867453 100644 --- a/github/users_keys.go +++ b/github/users_keys.go @@ -85,26 +85,6 @@ func (s *UsersService) CreateKey(key *Key) (*Key, *Response, error) { return k, resp, err } -// EditKey edits a public key. -// -// GitHub API docs: http://developer.github.com/v3/users/keys/#update-a-public-key -func (s *UsersService) EditKey(id int, key *Key) (*Key, *Response, error) { - u := fmt.Sprintf("user/keys/%v", id) - - req, err := s.client.NewRequest("PATCH", u, key) - if err != nil { - return nil, nil, err - } - - k := new(Key) - resp, err := s.client.Do(req, k) - if err != nil { - return nil, resp, err - } - - return k, resp, err -} - // DeleteKey deletes a public key. // // GitHub API docs: http://developer.github.com/v3/users/keys/#delete-a-public-key diff --git a/github/users_keys_test.go b/github/users_keys_test.go index a9f2542..794b064 100644 --- a/github/users_keys_test.go +++ b/github/users_keys_test.go @@ -107,35 +107,6 @@ func TestUsersService_CreateKey(t *testing.T) { } } -func TestUsersService_EditKey(t *testing.T) { - setup() - defer teardown() - - input := &Key{Key: String("k"), Title: String("t")} - - mux.HandleFunc("/user/keys/1", func(w http.ResponseWriter, r *http.Request) { - v := new(Key) - json.NewDecoder(r.Body).Decode(v) - - testMethod(t, r, "PATCH") - if !reflect.DeepEqual(v, input) { - t.Errorf("Request body = %+v, want %+v", v, input) - } - - fmt.Fprint(w, `{"id":1}`) - }) - - key, _, err := client.Users.EditKey(1, input) - if err != nil { - t.Errorf("Users.EditKey returned error: %v", err) - } - - want := &Key{ID: Int(1)} - if !reflect.DeepEqual(key, want) { - t.Errorf("Users.EditKey returned %+v, want %+v", key, want) - } -} - func TestUsersService_DeleteKey(t *testing.T) { setup() defer teardown()