From a1746f282059a5d71c4d8a270753698e164151e5 Mon Sep 17 00:00:00 2001 From: Don Petersen Date: Sun, 2 Oct 2016 21:18:34 +0000 Subject: [PATCH] Fix type of RepositoryRelease Author field. The author JSON is in the format of a user, not a commit author, and so the author field on all the release fetching methods were nil. Closes #439. Change-Id: Ifc1e79a3c92b27ea65618b16a3a2fd2eb2873710 --- github/repos_releases.go | 2 +- github/repos_releases_test.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/github/repos_releases.go b/github/repos_releases.go index e889b0d..331a4b7 100644 --- a/github/repos_releases.go +++ b/github/repos_releases.go @@ -34,7 +34,7 @@ type RepositoryRelease struct { UploadURL *string `json:"upload_url,omitempty"` ZipballURL *string `json:"zipball_url,omitempty"` TarballURL *string `json:"tarball_url,omitempty"` - Author *CommitAuthor `json:"author,omitempty"` + Author *User `json:"author,omitempty"` } func (r RepositoryRelease) String() string { diff --git a/github/repos_releases_test.go b/github/repos_releases_test.go index 412b245..99b6bef 100644 --- a/github/repos_releases_test.go +++ b/github/repos_releases_test.go @@ -44,7 +44,7 @@ func TestRepositoriesService_GetRelease(t *testing.T) { mux.HandleFunc("/repos/o/r/releases/1", func(w http.ResponseWriter, r *http.Request) { testMethod(t, r, "GET") - fmt.Fprint(w, `{"id":1}`) + fmt.Fprint(w, `{"id":1,"author":{"login":"l"}}`) }) release, resp, err := client.Repositories.GetRelease("o", "r", 1) @@ -52,7 +52,7 @@ func TestRepositoriesService_GetRelease(t *testing.T) { t.Errorf("Repositories.GetRelease returned error: %v\n%v", err, resp.Body) } - want := &RepositoryRelease{ID: Int(1)} + want := &RepositoryRelease{ID: Int(1), Author: &User{Login: String("l")}} if !reflect.DeepEqual(release, want) { t.Errorf("Repositories.GetRelease returned %+v, want %+v", release, want) }