From c6e655bba7c7cfb4eda7f6d6328559a7ec47644f Mon Sep 17 00:00:00 2001 From: Will Maier Date: Wed, 23 Nov 2016 21:43:33 -0800 Subject: [PATCH] Return IssueEvent in ListIssueEventsForRepository Fixes #176. Closes #475. Change-Id: I37f80bedbc689e1a8f97488e83dd69179dedcad4 --- github/activity_events.go | 4 ++-- github/activity_events_test.go | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/github/activity_events.go b/github/activity_events.go index 1515ca0..3cf37f4 100644 --- a/github/activity_events.go +++ b/github/activity_events.go @@ -142,7 +142,7 @@ func (s *ActivityService) ListRepositoryEvents(owner, repo string, opt *ListOpti // ListIssueEventsForRepository lists issue events for a repository. // // GitHub API docs: http://developer.github.com/v3/activity/events/#list-issue-events-for-a-repository -func (s *ActivityService) ListIssueEventsForRepository(owner, repo string, opt *ListOptions) ([]*Event, *Response, error) { +func (s *ActivityService) ListIssueEventsForRepository(owner, repo string, opt *ListOptions) ([]*IssueEvent, *Response, error) { u := fmt.Sprintf("repos/%v/%v/issues/events", owner, repo) u, err := addOptions(u, opt) if err != nil { @@ -154,7 +154,7 @@ func (s *ActivityService) ListIssueEventsForRepository(owner, repo string, opt * return nil, nil, err } - events := new([]*Event) + events := new([]*IssueEvent) resp, err := s.client.Do(req, events) if err != nil { return nil, resp, err diff --git a/github/activity_events_test.go b/github/activity_events_test.go index f8ffea7..2bb414b 100644 --- a/github/activity_events_test.go +++ b/github/activity_events_test.go @@ -75,7 +75,7 @@ func TestActivityService_ListIssueEventsForRepository(t *testing.T) { testFormValues(t, r, values{ "page": "2", }) - fmt.Fprint(w, `[{"id":"1"},{"id":"2"}]`) + fmt.Fprint(w, `[{"id":1},{"id":2}]`) }) opt := &ListOptions{Page: 2} @@ -84,7 +84,7 @@ func TestActivityService_ListIssueEventsForRepository(t *testing.T) { t.Errorf("Activities.ListIssueEventsForRepository returned error: %v", err) } - want := []*Event{{ID: String("1")}, {ID: String("2")}} + want := []*IssueEvent{{ID: Int(1)}, {ID: Int(2)}} if !reflect.DeepEqual(events, want) { t.Errorf("Activities.ListIssueEventsForRepository returned %+v, want %+v", events, want) }