From cca6b65b1077c999a90bd20f409bac962001364c Mon Sep 17 00:00:00 2001 From: Colin Misare Date: Wed, 2 Jul 2014 21:55:39 -0600 Subject: [PATCH] including ListOptions in RepositoryListForksOptions for pagination --- github/repos_forks.go | 2 ++ github/repos_forks_test.go | 10 ++++++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/github/repos_forks.go b/github/repos_forks.go index aeb24b2..1fec829 100644 --- a/github/repos_forks.go +++ b/github/repos_forks.go @@ -13,6 +13,8 @@ type RepositoryListForksOptions struct { // How to sort the forks list. Possible values are: newest, oldest, // watchers. Default is "newest". Sort string `url:"sort,omitempty"` + + ListOptions } // ListForks lists the forks of the specified repository. diff --git a/github/repos_forks_test.go b/github/repos_forks_test.go index b48cd5a..965a066 100644 --- a/github/repos_forks_test.go +++ b/github/repos_forks_test.go @@ -18,11 +18,17 @@ func TestRepositoriesService_ListForks(t *testing.T) { mux.HandleFunc("/repos/o/r/forks", func(w http.ResponseWriter, r *http.Request) { testMethod(t, r, "GET") - testFormValues(t, r, values{"sort": "newest"}) + testFormValues(t, r, values{ + "sort": "newest", + "page": "3", + }) fmt.Fprint(w, `[{"id":1},{"id":2}]`) }) - opt := &RepositoryListForksOptions{Sort: "newest"} + opt := &RepositoryListForksOptions{ + Sort: "newest", + ListOptions: ListOptions{Page: 3}, + } repos, _, err := client.Repositories.ListForks("o", "r", opt) if err != nil { t.Errorf("Repositories.ListForks returned error: %v", err)