Browse Source

remove unnecessary type declarations

when initializing a slice of concrete structs, it's not necessary to
declare the type of each item in the slice, since the compiler knows
what you mean.
Will Norris 13 years ago
parent
commit
db5ea50996
19 changed files with 43 additions and 43 deletions
  1. +4
    -4
      github/activity_events_test.go
  2. +2
    -2
      github/activity_star_test.go
  3. +4
    -4
      github/gists_test.go
  4. +1
    -1
      github/github_test.go
  5. +1
    -1
      github/issues_assignees_test.go
  6. +2
    -2
      github/issues_comments_test.go
  7. +5
    -5
      github/issues_labels_test.go
  8. +5
    -5
      github/issues_test.go
  9. +2
    -2
      github/orgs_members_test.go
  10. +3
    -3
      github/orgs_teams_test.go
  11. +2
    -2
      github/orgs_test.go
  12. +2
    -2
      github/pulls_comments_test.go
  13. +1
    -1
      github/pulls_test.go
  14. +1
    -1
      github/repos_collaborators_test.go
  15. +1
    -1
      github/repos_forks_test.go
  16. +1
    -1
      github/repos_hooks_test.go
  17. +1
    -1
      github/repos_statuses_test.go
  18. +4
    -4
      github/repos_test.go
  19. +1
    -1
      github/users_test.go

+ 4
- 4
github/activity_events_test.go View File

@ -31,7 +31,7 @@ func TestActivityService_ListEventsPerformedByUser_all(t *testing.T) {
t.Errorf("Events.ListPerformedByUser returned error: %v", err)
}
want := []Event{Event{ID: "1"}, Event{ID: "2"}}
want := []Event{{ID: "1"}, {ID: "2"}}
if !reflect.DeepEqual(events, want) {
t.Errorf("Events.ListPerformedByUser returned %+v, want %+v", events, want)
}
@ -51,7 +51,7 @@ func TestActivityService_ListEventsPerformedByUser_publicOnly(t *testing.T) {
t.Errorf("Events.ListPerformedByUser returned error: %v", err)
}
want := []Event{Event{ID: "1"}, Event{ID: "2"}}
want := []Event{{ID: "1"}, {ID: "2"}}
if !reflect.DeepEqual(events, want) {
t.Errorf("Events.ListPerformedByUser returned %+v, want %+v", events, want)
}
@ -75,7 +75,7 @@ func TestActivityService_ListEventsRecievedByUser_all(t *testing.T) {
t.Errorf("Events.ListRecievedByUser returned error: %v", err)
}
want := []Event{Event{ID: "1"}, Event{ID: "2"}}
want := []Event{{ID: "1"}, {ID: "2"}}
if !reflect.DeepEqual(events, want) {
t.Errorf("Events.ListRecievedUser returned %+v, want %+v", events, want)
}
@ -95,7 +95,7 @@ func TestActivityService_ListEventsRecievedByUser_publicOnly(t *testing.T) {
t.Errorf("Events.ListRecievedByUser returned error: %v", err)
}
want := []Event{Event{ID: "1"}, Event{ID: "2"}}
want := []Event{{ID: "1"}, {ID: "2"}}
if !reflect.DeepEqual(events, want) {
t.Errorf("Events.ListRecievedByUser returned %+v, want %+v", events, want)
}


+ 2
- 2
github/activity_star_test.go View File

@ -26,7 +26,7 @@ func TestActivityService_ListStarred_authenticatedUser(t *testing.T) {
t.Errorf("Activity.ListStarred returned error: %v", err)
}
want := []Repository{Repository{ID: 1}}
want := []Repository{{ID: 1}}
if !reflect.DeepEqual(repos, want) {
t.Errorf("Activity.ListStarred returned %+v, want %+v", repos, want)
}
@ -52,7 +52,7 @@ func TestActivityService_ListStarred_specifiedUser(t *testing.T) {
t.Errorf("Activity.ListStarred returned error: %v", err)
}
want := []Repository{Repository{ID: 2}}
want := []Repository{{ID: 2}}
if !reflect.DeepEqual(repos, want) {
t.Errorf("Activity.ListStarred returned %+v, want %+v", repos, want)
}


+ 4
- 4
github/gists_test.go View File

@ -35,7 +35,7 @@ func TestGistsService_List(t *testing.T) {
t.Errorf("Gists.List returned error: %v", err)
}
want := []Gist{Gist{ID: "1"}}
want := []Gist{{ID: "1"}}
if !reflect.DeepEqual(gists, want) {
t.Errorf("Gists.List returned %+v, want %+v", gists, want)
}
@ -55,7 +55,7 @@ func TestGistsService_List_withEmptyUser(t *testing.T) {
t.Errorf("Gists.List returned error: %v", err)
}
want := []Gist{Gist{ID: "1"}}
want := []Gist{{ID: "1"}}
if !reflect.DeepEqual(gists, want) {
t.Errorf("Gists.List returned %+v, want %+v", gists, want)
}
@ -82,7 +82,7 @@ func TestGistsService_ListAll(t *testing.T) {
t.Errorf("Gists.ListAll returned error: %v", err)
}
want := []Gist{Gist{ID: "1"}}
want := []Gist{{ID: "1"}}
if !reflect.DeepEqual(gists, want) {
t.Errorf("Gists.ListAll returned %+v, want %+v", gists, want)
}
@ -109,7 +109,7 @@ func TestGistsService_ListStarred(t *testing.T) {
t.Errorf("Gists.ListStarred returned error: %v", err)
}
want := []Gist{Gist{ID: "1"}}
want := []Gist{{ID: "1"}}
if !reflect.DeepEqual(gists, want) {
t.Errorf("Gists.ListStarred returned %+v, want %+v", gists, want)
}


+ 1
- 1
github/github_test.go View File

@ -333,7 +333,7 @@ func TestCheckResponse(t *testing.T) {
want := &ErrorResponse{
Response: res,
Message: "m",
Errors: []Error{Error{Resource: "r", Field: "f", Code: "c"}},
Errors: []Error{{Resource: "r", Field: "f", Code: "c"}},
}
if !reflect.DeepEqual(err, want) {
t.Errorf("Error = %#v, want %#v", err, want)


+ 1
- 1
github/issues_assignees_test.go View File

@ -26,7 +26,7 @@ func TestIssuesService_ListAssignees(t *testing.T) {
t.Errorf("Issues.List returned error: %v", err)
}
want := []User{User{ID: 1}}
want := []User{{ID: 1}}
if !reflect.DeepEqual(assignees, want) {
t.Errorf("Issues.ListAssignees returned %+v, want %+v", assignees, want)
}


+ 2
- 2
github/issues_comments_test.go View File

@ -36,7 +36,7 @@ func TestIssuesService_ListComments_allIssues(t *testing.T) {
t.Errorf("Issues.ListComments returned error: %v", err)
}
want := []IssueComment{IssueComment{ID: 1}}
want := []IssueComment{{ID: 1}}
if !reflect.DeepEqual(comments, want) {
t.Errorf("Issues.ListComments returned %+v, want %+v", comments, want)
}
@ -56,7 +56,7 @@ func TestIssuesService_ListComments_specificIssue(t *testing.T) {
t.Errorf("Issues.ListComments returned error: %v", err)
}
want := []IssueComment{IssueComment{ID: 1}}
want := []IssueComment{{ID: 1}}
if !reflect.DeepEqual(comments, want) {
t.Errorf("Issues.ListComments returned %+v, want %+v", comments, want)
}


+ 5
- 5
github/issues_labels_test.go View File

@ -27,7 +27,7 @@ func TestIssuesService_ListLabels(t *testing.T) {
t.Errorf("Issues.ListLabels returned error: %v", err)
}
want := []Label{Label{Name: "a"}, Label{Name: "b"}}
want := []Label{{Name: "a"}, {Name: "b"}}
if !reflect.DeepEqual(labels, want) {
t.Errorf("Issues.ListLabels returned %+v, want %+v", labels, want)
}
@ -139,7 +139,7 @@ func TestIssuesService_ListLabelsByIssue(t *testing.T) {
t.Errorf("Issues.ListLabelsByIssue returned error: %v", err)
}
want := []Label{Label{Name: "a"}, Label{Name: "b"}}
want := []Label{{Name: "a"}, {Name: "b"}}
if !reflect.DeepEqual(labels, want) {
t.Errorf("Issues.ListLabelsByIssue returned %+v, want %+v", labels, want)
}
@ -168,7 +168,7 @@ func TestIssuesService_AddLabelsToIssue(t *testing.T) {
t.Errorf("Issues.AddLabelsToIssue returned error: %v", err)
}
want := []Label{Label{URL: "u"}}
want := []Label{{URL: "u"}}
if !reflect.DeepEqual(labels, want) {
t.Errorf("Issues.AddLabelsToIssue returned %+v, want %+v", labels, want)
}
@ -211,7 +211,7 @@ func TestIssuesService_ReplaceLabelsForIssue(t *testing.T) {
t.Errorf("Issues.ReplaceLabelsForIssue returned error: %v", err)
}
want := []Label{Label{URL: "u"}}
want := []Label{{URL: "u"}}
if !reflect.DeepEqual(labels, want) {
t.Errorf("Issues.ReplaceLabelsForIssue returned %+v, want %+v", labels, want)
}
@ -245,7 +245,7 @@ func TestIssuesService_ListLabelsForMilestone(t *testing.T) {
t.Errorf("Issues.ListLabelsForMilestone returned error: %v", err)
}
want := []Label{Label{Name: "a"}, Label{Name: "b"}}
want := []Label{{Name: "a"}, {Name: "b"}}
if !reflect.DeepEqual(labels, want) {
t.Errorf("Issues.ListLabelsForMilestone returned %+v, want %+v", labels, want)
}


+ 5
- 5
github/issues_test.go View File

@ -43,7 +43,7 @@ func TestIssuesService_List_all(t *testing.T) {
t.Errorf("Issues.List returned error: %v", err)
}
want := []Issue{Issue{Number: 1}}
want := []Issue{{Number: 1}}
if !reflect.DeepEqual(issues, want) {
t.Errorf("Issues.List returned %+v, want %+v", issues, want)
}
@ -63,7 +63,7 @@ func TestIssuesService_List_owned(t *testing.T) {
t.Errorf("Issues.List returned error: %v", err)
}
want := []Issue{Issue{Number: 1}}
want := []Issue{{Number: 1}}
if !reflect.DeepEqual(issues, want) {
t.Errorf("Issues.List returned %+v, want %+v", issues, want)
}
@ -83,7 +83,7 @@ func TestIssuesService_ListByOrg(t *testing.T) {
t.Errorf("Issues.ListByOrg returned error: %v", err)
}
want := []Issue{Issue{Number: 1}}
want := []Issue{{Number: 1}}
if !reflect.DeepEqual(issues, want) {
t.Errorf("Issues.List returned %+v, want %+v", issues, want)
}
@ -123,7 +123,7 @@ func TestIssuesService_ListByRepo(t *testing.T) {
t.Errorf("Issues.ListByOrg returned error: %v", err)
}
want := []Issue{Issue{Number: 1}}
want := []Issue{{Number: 1}}
if !reflect.DeepEqual(issues, want) {
t.Errorf("Issues.List returned %+v, want %+v", issues, want)
}
@ -148,7 +148,7 @@ func TestIssuesService_Get(t *testing.T) {
t.Errorf("Issues.Get returned error: %v", err)
}
want := &Issue{Number: 1, Labels: []Label{Label{URL: "u", Name: "n", Color: "c"}}}
want := &Issue{Number: 1, Labels: []Label{{URL: "u", Name: "n", Color: "c"}}}
if !reflect.DeepEqual(issue, want) {
t.Errorf("Issues.Get returned %+v, want %+v", issue, want)
}


+ 2
- 2
github/orgs_members_test.go View File

@ -26,7 +26,7 @@ func TestOrganizationsService_ListMembers(t *testing.T) {
t.Errorf("Organizations.ListMembers returned error: %v", err)
}
want := []User{User{ID: 1}}
want := []User{{ID: 1}}
if !reflect.DeepEqual(members, want) {
t.Errorf("Organizations.ListMembers returned %+v, want %+v", members, want)
}
@ -51,7 +51,7 @@ func TestOrganizationsService_ListPublicMembers(t *testing.T) {
t.Errorf("Organizations.ListPublicMembers returned error: %v", err)
}
want := []User{User{ID: 1}}
want := []User{{ID: 1}}
if !reflect.DeepEqual(members, want) {
t.Errorf("Organizations.ListPublicMembers returned %+v, want %+v", members, want)
}


+ 3
- 3
github/orgs_teams_test.go View File

@ -27,7 +27,7 @@ func TestOrganizationsService_ListTeams(t *testing.T) {
t.Errorf("Organizations.ListTeams returned error: %v", err)
}
want := []Team{Team{ID: 1}}
want := []Team{{ID: 1}}
if !reflect.DeepEqual(teams, want) {
t.Errorf("Organizations.ListTeams returned %+v, want %+v", teams, want)
}
@ -149,7 +149,7 @@ func TestOrganizationsService_ListTeamMembers(t *testing.T) {
t.Errorf("Organizations.ListTeamMembers returned error: %v", err)
}
want := []User{User{ID: 1}}
want := []User{{ID: 1}}
if !reflect.DeepEqual(members, want) {
t.Errorf("Organizations.ListTeamMembers returned %+v, want %+v", members, want)
}
@ -310,7 +310,7 @@ func TestOrganizationsService_ListTeamRepos(t *testing.T) {
t.Errorf("Organizations.ListTeamRepos returned error: %v", err)
}
want := []Repository{Repository{ID: 1}}
want := []Repository{{ID: 1}}
if !reflect.DeepEqual(members, want) {
t.Errorf("Organizations.ListTeamRepos returned %+v, want %+v", members, want)
}


+ 2
- 2
github/orgs_test.go View File

@ -27,7 +27,7 @@ func TestOrganizationsService_List_authenticatedUser(t *testing.T) {
t.Errorf("Organizations.List returned error: %v", err)
}
want := []Organization{Organization{ID: 1}, Organization{ID: 2}}
want := []Organization{{ID: 1}, {ID: 2}}
if !reflect.DeepEqual(orgs, want) {
t.Errorf("Organizations.List returned %+v, want %+v", orgs, want)
}
@ -49,7 +49,7 @@ func TestOrganizationsService_List_specifiedUser(t *testing.T) {
t.Errorf("Organizations.List returned error: %v", err)
}
want := []Organization{Organization{ID: 1}, Organization{ID: 2}}
want := []Organization{{ID: 1}, {ID: 2}}
if !reflect.DeepEqual(orgs, want) {
t.Errorf("Organizations.List returned %+v, want %+v", orgs, want)
}


+ 2
- 2
github/pulls_comments_test.go View File

@ -37,7 +37,7 @@ func TestPullRequestsService_ListComments_allPulls(t *testing.T) {
t.Errorf("PullRequests.ListComments returned error: %v", err)
}
want := []PullRequestComment{PullRequestComment{ID: 1}}
want := []PullRequestComment{{ID: 1}}
if !reflect.DeepEqual(pulls, want) {
t.Errorf("PullRequests.ListComments returned %+v, want %+v", pulls, want)
}
@ -58,7 +58,7 @@ func TestPullRequestsService_ListComments_specificPull(t *testing.T) {
t.Errorf("PullRequests.ListComments returned error: %v", err)
}
want := []PullRequestComment{PullRequestComment{ID: 1}}
want := []PullRequestComment{{ID: 1}}
if !reflect.DeepEqual(pulls, want) {
t.Errorf("PullRequests.ListComments returned %+v, want %+v", pulls, want)
}


+ 1
- 1
github/pulls_test.go View File

@ -34,7 +34,7 @@ func TestPullRequestsService_List(t *testing.T) {
t.Errorf("PullRequests.List returned error: %v", err)
}
want := []PullRequest{PullRequest{Number: 1}}
want := []PullRequest{{Number: 1}}
if !reflect.DeepEqual(pulls, want) {
t.Errorf("PullRequests.List returned %+v, want %+v", pulls, want)
}


+ 1
- 1
github/repos_collaborators_test.go View File

@ -26,7 +26,7 @@ func TestRepositoriesService_ListCollaborators(t *testing.T) {
t.Errorf("Repositories.ListCollaborators returned error: %v", err)
}
want := []User{User{ID: 1}, User{ID: 2}}
want := []User{{ID: 1}, {ID: 2}}
if !reflect.DeepEqual(users, want) {
t.Errorf("Repositories.ListCollaborators returned %+v, want %+v", users, want)
}


+ 1
- 1
github/repos_forks_test.go View File

@ -28,7 +28,7 @@ func TestRepositoriesService_ListForks(t *testing.T) {
t.Errorf("Repositories.ListForks returned error: %v", err)
}
want := []Repository{Repository{ID: 1}, Repository{ID: 2}}
want := []Repository{{ID: 1}, {ID: 2}}
if !reflect.DeepEqual(repos, want) {
t.Errorf("Repositories.ListForks returned %+v, want %+v", repos, want)
}


+ 1
- 1
github/repos_hooks_test.go View File

@ -59,7 +59,7 @@ func TestRepositoriesService_ListHooks(t *testing.T) {
t.Errorf("Repositories.ListHooks returned error: %v", err)
}
want := []Hook{Hook{ID: 1}, Hook{ID: 2}}
want := []Hook{{ID: 1}, {ID: 2}}
if !reflect.DeepEqual(hooks, want) {
t.Errorf("Repositories.ListHooks returned %+v, want %+v", hooks, want)
}


+ 1
- 1
github/repos_statuses_test.go View File

@ -27,7 +27,7 @@ func TestRepositoriesService_ListStatuses(t *testing.T) {
t.Errorf("Repositories.ListStatuses returned error: %v", err)
}
want := []RepoStatus{RepoStatus{ID: 1}}
want := []RepoStatus{{ID: 1}}
if !reflect.DeepEqual(statuses, want) {
t.Errorf("Repositories.ListStatuses returned %+v, want %+v", statuses, want)
}


+ 4
- 4
github/repos_test.go View File

@ -27,7 +27,7 @@ func TestRepositoriesService_List_authenticatedUser(t *testing.T) {
t.Errorf("Repositories.List returned error: %v", err)
}
want := []Repository{Repository{ID: 1}, Repository{ID: 2}}
want := []Repository{{ID: 1}, {ID: 2}}
if !reflect.DeepEqual(repos, want) {
t.Errorf("Repositories.List returned %+v, want %+v", repos, want)
}
@ -55,7 +55,7 @@ func TestRepositoriesService_List_specifiedUser(t *testing.T) {
t.Errorf("Repositories.List returned error: %v", err)
}
want := []Repository{Repository{ID: 1}}
want := []Repository{{ID: 1}}
if !reflect.DeepEqual(repos, want) {
t.Errorf("Repositories.List returned %+v, want %+v", repos, want)
}
@ -85,7 +85,7 @@ func TestRepositoriesService_ListByOrg(t *testing.T) {
t.Errorf("Repositories.ListByOrg returned error: %v", err)
}
want := []Repository{Repository{ID: 1}}
want := []Repository{{ID: 1}}
if !reflect.DeepEqual(repos, want) {
t.Errorf("Repositories.ListByOrg returned %+v, want %+v", repos, want)
}
@ -112,7 +112,7 @@ func TestRepositoriesService_ListAll(t *testing.T) {
t.Errorf("Repositories.ListAll returned error: %v", err)
}
want := []Repository{Repository{ID: 1}}
want := []Repository{{ID: 1}}
if !reflect.DeepEqual(repos, want) {
t.Errorf("Repositories.ListAll returned %+v, want %+v", repos, want)
}


+ 1
- 1
github/users_test.go View File

@ -103,7 +103,7 @@ func TestUsersService_ListAll(t *testing.T) {
t.Errorf("Users.Get returned error: %v", err)
}
want := []User{User{ID: 2}}
want := []User{{ID: 2}}
if !reflect.DeepEqual(users, want) {
t.Errorf("Users.ListAll returned %+v, want %+v", users, want)
}


Loading…
Cancel
Save