From b5ecf012dba1882025b19d472715d8f6c2a9e85e Mon Sep 17 00:00:00 2001 From: Justin LeFebvre Date: Sun, 6 Jul 2014 18:11:42 -0400 Subject: [PATCH 1/2] really minor change to the logic here --- semver.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/semver.go b/semver.go index 0238004..c363131 100644 --- a/semver.go +++ b/semver.go @@ -360,11 +360,8 @@ func containsOnly(s string, set string) bool { } func hasLeadingZeroes(s string) bool { - if len(s) <= 1 { - return false - } - if s[0] == '0' { - return true + if len(s) > 1 { + return strings.HasPrefix(s, "0") } return false } From 50c0e52521a7fc0cf14f1b95948bc8246c97266b Mon Sep 17 00:00:00 2001 From: Justin LeFebvre Date: Wed, 9 Jul 2014 17:35:02 -0400 Subject: [PATCH 2/2] much simpler logic without requiring a branch condition --- semver.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/semver.go b/semver.go index c363131..b6bc9bb 100644 --- a/semver.go +++ b/semver.go @@ -360,10 +360,7 @@ func containsOnly(s string, set string) bool { } func hasLeadingZeroes(s string) bool { - if len(s) > 1 { - return strings.HasPrefix(s, "0") - } - return false + return len(s) > 1 && s[0] == '0' } // Creates a new valid build version