Note that `TestUsers_Keys` still fails for general users
but will need to be addressed later.
Fixes#366.
Change-Id: I35d8a73c2daed08df7d60085b1585f48caee9a95
As with the previous key added in 19c0916, I deleted the associated
private key using /usr/bin/shred. But of course, I have no way to prove
that. Again, all the more reason to always use a test account when
running these integration tests.
This includes all of the methods mentioned in this blog post:
https://developer.github.com/changes/2014-03-18-paginating-method-changes/
as well as a handful of others I found. Sadly, this is a breaking
change for many of these methods because it changes the method
signature, but with yesterday's API change these methods are now broken
anyway. :(
The test public key used in these tests is a key that I just generated
specifically for this purpose. I deleted the associated private key, so
even if someone accidentally left this attached to their account, it
should have no effect. Of course, I have no way of actually proving
that I deleted the private key, so uh... yeah. All the more reason to
never run these integration tests using a "real" GitHub account, always
use a dedicated test account.
The GitHub docs don't make it completely clear that AddEmails is also
switching to the new v3 response format, but new integration tests
verify that it is.
This is a breaking change, but it appears that this method has been
broken for some time now and no one has complained yet, so I'm going to
assume no one is using it yet.
Notably, this is also the first (of many, I'm sure) bug I've discovered
while working on the new integration tests (#98). Yay for better tests!
Glenn Lewis
Will Norris