Browse Source

Fix type of RepositoryRelease Author field.

The author JSON is in the format of a user, not a commit author, and so
the author field on all the release fetching methods were nil.

Closes #439.

Change-Id: Ifc1e79a3c92b27ea65618b16a3a2fd2eb2873710
Don Petersen 9 years ago
committed by Glenn Lewis
parent
commit
a1746f2820
2 changed files with 3 additions and 3 deletions
  1. +1
    -1
      github/repos_releases.go
  2. +2
    -2
      github/repos_releases_test.go

+ 1
- 1
github/repos_releases.go View File

@ -34,7 +34,7 @@ type RepositoryRelease struct {
UploadURL *string `json:"upload_url,omitempty"` UploadURL *string `json:"upload_url,omitempty"`
ZipballURL *string `json:"zipball_url,omitempty"` ZipballURL *string `json:"zipball_url,omitempty"`
TarballURL *string `json:"tarball_url,omitempty"` TarballURL *string `json:"tarball_url,omitempty"`
Author *CommitAuthor `json:"author,omitempty"`
Author *User `json:"author,omitempty"`
} }
func (r RepositoryRelease) String() string { func (r RepositoryRelease) String() string {


+ 2
- 2
github/repos_releases_test.go View File

@ -44,7 +44,7 @@ func TestRepositoriesService_GetRelease(t *testing.T) {
mux.HandleFunc("/repos/o/r/releases/1", func(w http.ResponseWriter, r *http.Request) { mux.HandleFunc("/repos/o/r/releases/1", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "GET") testMethod(t, r, "GET")
fmt.Fprint(w, `{"id":1}`)
fmt.Fprint(w, `{"id":1,"author":{"login":"l"}}`)
}) })
release, resp, err := client.Repositories.GetRelease("o", "r", 1) release, resp, err := client.Repositories.GetRelease("o", "r", 1)
@ -52,7 +52,7 @@ func TestRepositoriesService_GetRelease(t *testing.T) {
t.Errorf("Repositories.GetRelease returned error: %v\n%v", err, resp.Body) t.Errorf("Repositories.GetRelease returned error: %v\n%v", err, resp.Body)
} }
want := &RepositoryRelease{ID: Int(1)}
want := &RepositoryRelease{ID: Int(1), Author: &User{Login: String("l")}}
if !reflect.DeepEqual(release, want) { if !reflect.DeepEqual(release, want) {
t.Errorf("Repositories.GetRelease returned %+v, want %+v", release, want) t.Errorf("Repositories.GetRelease returned %+v, want %+v", release, want)
} }


Loading…
Cancel
Save