Browse Source

Return IssueEvent in ListIssueEventsForRepository

Fixes #176.
Closes #475.

Change-Id: I37f80bedbc689e1a8f97488e83dd69179dedcad4
Will Maier 9 years ago
committed by Glenn Lewis
parent
commit
c6e655bba7
2 changed files with 4 additions and 4 deletions
  1. +2
    -2
      github/activity_events.go
  2. +2
    -2
      github/activity_events_test.go

+ 2
- 2
github/activity_events.go View File

@ -142,7 +142,7 @@ func (s *ActivityService) ListRepositoryEvents(owner, repo string, opt *ListOpti
// ListIssueEventsForRepository lists issue events for a repository. // ListIssueEventsForRepository lists issue events for a repository.
// //
// GitHub API docs: http://developer.github.com/v3/activity/events/#list-issue-events-for-a-repository // GitHub API docs: http://developer.github.com/v3/activity/events/#list-issue-events-for-a-repository
func (s *ActivityService) ListIssueEventsForRepository(owner, repo string, opt *ListOptions) ([]*Event, *Response, error) {
func (s *ActivityService) ListIssueEventsForRepository(owner, repo string, opt *ListOptions) ([]*IssueEvent, *Response, error) {
u := fmt.Sprintf("repos/%v/%v/issues/events", owner, repo) u := fmt.Sprintf("repos/%v/%v/issues/events", owner, repo)
u, err := addOptions(u, opt) u, err := addOptions(u, opt)
if err != nil { if err != nil {
@ -154,7 +154,7 @@ func (s *ActivityService) ListIssueEventsForRepository(owner, repo string, opt *
return nil, nil, err return nil, nil, err
} }
events := new([]*Event)
events := new([]*IssueEvent)
resp, err := s.client.Do(req, events) resp, err := s.client.Do(req, events)
if err != nil { if err != nil {
return nil, resp, err return nil, resp, err


+ 2
- 2
github/activity_events_test.go View File

@ -75,7 +75,7 @@ func TestActivityService_ListIssueEventsForRepository(t *testing.T) {
testFormValues(t, r, values{ testFormValues(t, r, values{
"page": "2", "page": "2",
}) })
fmt.Fprint(w, `[{"id":"1"},{"id":"2"}]`)
fmt.Fprint(w, `[{"id":1},{"id":2}]`)
}) })
opt := &ListOptions{Page: 2} opt := &ListOptions{Page: 2}
@ -84,7 +84,7 @@ func TestActivityService_ListIssueEventsForRepository(t *testing.T) {
t.Errorf("Activities.ListIssueEventsForRepository returned error: %v", err) t.Errorf("Activities.ListIssueEventsForRepository returned error: %v", err)
} }
want := []*Event{{ID: String("1")}, {ID: String("2")}}
want := []*IssueEvent{{ID: Int(1)}, {ID: Int(2)}}
if !reflect.DeepEqual(events, want) { if !reflect.DeepEqual(events, want) {
t.Errorf("Activities.ListIssueEventsForRepository returned %+v, want %+v", events, want) t.Errorf("Activities.ListIssueEventsForRepository returned %+v, want %+v", events, want)
} }


Loading…
Cancel
Save